Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove services json file after dive clean and update verbose flag #89

Merged
merged 2 commits into from
Aug 2, 2023
Merged

fix: remove services json file after dive clean and update verbose flag #89

merged 2 commits into from
Aug 2, 2023

Conversation

shreyasbhat0
Copy link
Contributor

Description:

Commit Message

fix: remove services json file after dive clean and update verbose flag

see the guidelines for commit messages.

Checklist:

  • I have performed a self-review of my own code
  • I have documented my code in accordance with the documentation guidelines
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have run the unit tests
  • I only have one commit (if not, squash them into one commit).
  • I have a descriptive commit message that adheres to the commit message guidelines

Please review the CONTRIBUTING.md file for detailed contributing guidelines.

@shreyasbhat0 shreyasbhat0 added the tracked issues This is a known issue by the DIVE dev team and will be fixed in the upcoming release label Aug 2, 2023
@shreyasbhat0 shreyasbhat0 requested a review from hemz10 August 2, 2023 06:26
@shreyasbhat0 shreyasbhat0 self-assigned this Aug 2, 2023
@shreyasbhat0 shreyasbhat0 removed the tracked issues This is a known issue by the DIVE dev team and will be fixed in the upcoming release label Aug 2, 2023
@hemz10 hemz10 merged commit af8606b into main Aug 2, 2023
@hemz10 hemz10 deleted the fix/remove-services-json-file-after-dive-clean branch August 2, 2023 06:27
shreyasbhat0 added a commit that referenced this pull request Jan 24, 2024
@shreyasbhat0
fix: remove services json file after dive clean and update verbose fl…
6783c90 
…ag (#89)

* fix: remove services json on dive clean and update log

* fix: update verbose flag
shreyasbhat0 added a commit that referenced this pull request Jan 25, 2024
@shreyasbhat0
Merge pull request #89 from HugoByte/kusama-polkadot-issues
e8bc395 
feat: added feature to pass public ports from cli to package
Mr-Nobody21 pushed a commit to Mr-Nobody21/DIVE that referenced this pull request May 7, 2024
@shreyasbhat0
fix: remove services json file after dive clean and update verbose fl…
2f9d43b 
…ag (HugoByte#89)

* fix: remove services json on dive clean and update log

* fix: update verbose flag
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hemz10 hemz10 hemz10 approved these changes

Assignees

@shreyasbhat0 shreyasbhat0

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shreyasbhat0 @hemz10