Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: implement error handling , Service stopper on Error and Improve Logging #57

Merged
merged 11 commits into from
Jul 27, 2023
Merged

feat: implement error handling , Service stopper on Error and Improve Logging #57

merged 11 commits into from
Jul 27, 2023

Conversation

shreyasbhat0
Copy link
Contributor

@shreyasbhat0 shreyasbhat0 commented Jul 25, 2023 •
edited
Loading

Description:

Commit Message

feat: implement error handling , service stopper on error and improve logging

see the guidelines for commit messages.

Checklist:

  • I have performed a self-review of my own code
  • I have documented my code in accordance with the documentation guidelines
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have run the unit tests
  • I only have one commit (if not, squash them into one commit).
  • I have a descriptive commit message that adheres to the commit message guidelines

Please review the CONTRIBUTING.md file for detailed contributing guidelines.

@shreyasbhat0 shreyasbhat0 added the enhancement New feature or request label Jul 25, 2023
@shreyasbhat0 shreyasbhat0 requested a review from hemz10 July 25, 2023 10:46
@shreyasbhat0 shreyasbhat0 self-assigned this Jul 25, 2023
@shreyasbhat0 shreyasbhat0 mentioned this pull request Jul 25, 2023
Closed
@Mr-Nobody21 Mr-Nobody21 mentioned this pull request Jul 26, 2023
Closed
This was referenced Jul 26, 2023
Closed
Closed
@shreyasbhat0 shreyasbhat0 mentioned this pull request Jul 26, 2023
Closed
@Mr-Nobody21 Mr-Nobody21 self-requested a review July 27, 2023 06:21
@Mr-Nobody21 Mr-Nobody21 merged commit 703f21e into main Jul 27, 2023
@Mr-Nobody21 Mr-Nobody21 deleted the hotfix/fix-dive-context branch July 27, 2023 06:22
shreyasbhat0 added a commit that referenced this pull request Jan 24, 2024
@shreyasbhat0
feat: implement error handling , Service stopper on Error and Improve…
cc300c1 
… Logging (#57)

* fix: typo in logging

* chore: remove log formatter

* fix: dive version is now independent on kurtosis engine

* feat: update logging , implement verbose logging

* feat: implement stop service on starlark run failure

* feat: update logger

* feat: update eth package

* feat: update logger to handle logs to files

* refactor: refactor imports

* fix: stop spinner on error and print logs , handle file while starting icon node and fix multilog files

* chore: bump kurtosis sdk version
Mr-Nobody21 pushed a commit to Mr-Nobody21/DIVE that referenced this pull request May 7, 2024
@shreyasbhat0
feat: implement error handling , Service stopper on Error and Improve…
94aa54b 
… Logging (HugoByte#57)

* fix: typo in logging

* chore: remove log formatter

* fix: dive version is now independent on kurtosis engine

* feat: update logging , implement verbose logging

* feat: implement stop service on starlark run failure

* feat: update logger

* feat: update eth package

* feat: update logger to handle logs to files

* refactor: refactor imports

* fix: stop spinner on error and print logs , handle file while starting icon node and fix multilog files

* chore: bump kurtosis sdk version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mr-Nobody21 Mr-Nobody21 Mr-Nobody21 approved these changes

@hemz10 hemz10 Awaiting requested review from hemz10

Assignees

@shreyasbhat0 shreyasbhat0

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shreyasbhat0 @Mr-Nobody21