Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: bug fix for nil pointer error and fix bridge #105

Merged
merged 17 commits into from
Aug 11, 2023
Merged

fix: bug fix for nil pointer error and fix bridge #105

merged 17 commits into from
Aug 11, 2023

Conversation

shreyasbhat0
Copy link
Contributor

Description:

Commit Message

fix: bug fix for nil pointer error and fix bridge

see the guidelines for commit messages.

Changelog Entry

version: bug fixes and minor updates

Checklist:

  • I have performed a self-review of my own code
  • I have documented my code in accordance with the documentation guidelines
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have run the unit tests
  • I only have one commit (if not, squash them into one commit).
  • I have a descriptive commit message that adheres to the commit message guidelines

Please review the CONTRIBUTING.md file for detailed contributing guidelines.

@shreyasbhat0 shreyasbhat0 added the test:smoke PR with this labels will run the smoke test script label Aug 11, 2023
@shreyasbhat0 shreyasbhat0 requested a review from hemz10 August 11, 2023 05:43
@shreyasbhat0 shreyasbhat0 self-assigned this Aug 11, 2023
@shreyasbhat0 shreyasbhat0 added test:smoke PR with this labels will run the smoke test script and removed test:smoke PR with this labels will run the smoke test script labels Aug 11, 2023
@Mr-Nobody21 Mr-Nobody21 self-requested a review August 11, 2023 06:10
@shreyasbhat0 shreyasbhat0 added test:smoke PR with this labels will run the smoke test script and removed test:smoke PR with this labels will run the smoke test script labels Aug 11, 2023
@shreyasbhat0 shreyasbhat0 added test:smoke PR with this labels will run the smoke test script and removed test:smoke PR with this labels will run the smoke test script labels Aug 11, 2023
@Mr-Nobody21 Mr-Nobody21 merged commit 6aab34a into main Aug 11, 2023
@Mr-Nobody21 Mr-Nobody21 deleted the fix/fix-nil-pointer-error-and-chain-running branch August 11, 2023 08:51
shreyasbhat0 added a commit that referenced this pull request Jan 24, 2024
@shreyasbhat0
fix: bug fix for nil pointer error and fix bridge (#105)
03ba878 
* chore: initial cosmos setup

* feat: update starlark package for cosmos nodes and cosmos relays

* feat: update icon starlark package

* feat: restructure btp setup

* feat: update eth and hardhat btp setup

* fix: bridge btp chainA other icon fails

* fix: start bridge with single chain already running

* fix: run bridge with single chain running

* fix: variable assignment

* fix: typo in command name

* fix: add gas price for eth deployment

* fix: update gas price

* chore: update version and goreleaser
shreyasbhat0 added a commit that referenced this pull request Jan 25, 2024
@shreyasbhat0
Merge pull request #105 from HugoByte/internal-allocation-of-ports
f8db633 
feat: implement allocation of ports inside dive cli instead of passing in config
Mr-Nobody21 pushed a commit to Mr-Nobody21/DIVE that referenced this pull request May 7, 2024
@shreyasbhat0
fix: bug fix for nil pointer error and fix bridge (HugoByte#105)
9d8a398 
* chore: initial cosmos setup

* feat: update starlark package for cosmos nodes and cosmos relays

* feat: update icon starlark package

* feat: restructure btp setup

* feat: update eth and hardhat btp setup

* fix: bridge btp chainA other icon fails

* fix: start bridge with single chain already running

* fix: run bridge with single chain running

* fix: variable assignment

* fix: typo in command name

* fix: add gas price for eth deployment

* fix: update gas price

* chore: update version and goreleaser
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mr-Nobody21 Mr-Nobody21 Mr-Nobody21 approved these changes

@hemz10 hemz10 Awaiting requested review from hemz10

Assignees

@shreyasbhat0 shreyasbhat0

Labels
test:smoke PR with this labels will run the smoke test script
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shreyasbhat0 @Mr-Nobody21