Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Successful message output even when unknown chain type is given for ibc bridge #129

Closed
hemz10 opened this issue Aug 18, 2023 · 2 comments
Closed

Successful message output even when unknown chain type is given for ibc bridge #129

hemz10 opened this issue Aug 18, 2023 · 2 comments

Comments

@hemz10
Copy link
Contributor

hemz10 commented Aug 18, 2023

Overview

chainA or chainB is unknown chain type is given we are still getting an output that dive.json is generated.

Steps to Reproduce

Steps to reproduce the behavior:

  1. run dive bridge ibc --chainA archway --chainB invalid_chain
  2. Observe we are getting successful message.

Expected Behavior

Should validate chain name initially and should fail if invalid chain type is given
@shreyasbhat0
Copy link
Contributor

#146 fixes this issues

@hemz10
Copy link
Contributor Author

hemz10 commented Aug 28, 2023

Closing this issue as fixed.
Current implementation supports only archway for ibc
image

@hemz10 hemz10 closed this as completed Aug 28, 2023
shreyasbhat0 added a commit that referenced this issue Jan 25, 2024
@shreyasbhat0
Merge pull request #129 from HugoByte/DV-27-Update-github-actions
fe1d0ca 
refactor: refactoring github actions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@shreyasbhat0 @hemz10