Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix argument ordering #3156

Merged
merged 2 commits into from
Oct 13, 2024
Merged

Fix argument ordering #3156

merged 2 commits into from
Oct 13, 2024

Conversation

filvuk
Copy link
Contributor

@filvuk filvuk commented Oct 9, 2024

Purpose

Fix described in #3150.

Copy link

netlify bot commented Oct 9, 2024

Deploy Preview for academic-demo ready!

Name Link
🔨 Latest commit 7e3cf6c
🔍 Latest deploy log https://app.netlify.com/sites/academic-demo/deploys/670aee789c29ea0008a11271
😎 Deploy Preview https://deploy-preview-3156--academic-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@gcushen gcushen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are two instances of this code snippet - the other instance is for the v1 version of the block:

{{ $filter_default := default (int $block.Params.content.filter_default) 0 }}

Please update that block too so we can merge the PR.

Thanks

@gcushen gcushen added the bug label Oct 12, 2024
@filvuk
Copy link
Contributor Author

filvuk commented Oct 12, 2024

Sure thing. PR updated.

@gcushen gcushen merged commit fdf45ba into HugoBlox:main Oct 13, 2024
5 checks passed
@gcushen
Copy link
Collaborator

gcushen commented Oct 13, 2024

@filvuk thanks for contributing :)

@filvuk
Copy link
Contributor Author

filvuk commented Oct 13, 2024

@gcushen Of course! Thanks for all your work on this project! 🙏

@filvuk filvuk deleted the patch-1 branch October 13, 2024 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants