Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move media library from static/ to assets/ #2119

Closed
4 of 5 tasks
gcushen opened this issue Jan 23, 2021 · 1 comment
Closed
4 of 5 tasks

Move media library from static/ to assets/ #2119

gcushen opened this issue Jan 23, 2021 · 1 comment
Milestone

Comments

@gcushen
Copy link
Collaborator

gcushen commented Jan 23, 2021

Workaround Hugo's image processing limitation in static/.

To support #1988 in case where an image is used in multiple pages and requires processing.

Otherwise, for single use images, they can be placed in a page's own folder for processing.

  • Update lib. path in CMS
  • Update all code referring to media_dir (which represents the static/ location)
    • widget page BGs
    • ...
  • Update staticref shortcode to enable loading PDF from assets/media/
    • DESCOPED - consider if there's need to intro similar shortcode relative to assets/ in future

Breaking changes:

Gallery is now intended only for local images in the page bundle (so that they can be optimized by Hugo).

@gcushen gcushen added this to the v5.0 - Refresh milestone Jan 23, 2021
@gcushen gcushen modified the milestones: v5.0, v5.1 Feb 16, 2021
@Shatur
Copy link

Shatur commented Mar 24, 2021

Gallery is now intended only for local images in the page bundle (so that they can be optimized by Hugo).

@gcushen, is it possible to share images between pages? I have the same image for different languages ​​(these pages have different folders).
I tried the alternative method from the documentation but it doesn't work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants