Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug/fix up menu box choice and scale #897

Merged
merged 7 commits into from
Feb 20, 2019
Merged

Bug/fix up menu box choice and scale #897

merged 7 commits into from
Feb 20, 2019

Conversation

gfodor
Copy link
Contributor

@gfodor gfodor commented Feb 16, 2019

Fixes up some basic usability issues with the popup menus:

  • Uses the dot product between the box face normal and the camera to determine which box face to show the menu on, vs just a basic distance check. This prevents the issue where the camera can't see the menu because its perpendicular.

  • Fixes an issue with skewed objects (like 2d planes) which causes the menu to not scale. Instead the scaling factor is now based upon the max (x, z) scale of the box.

  • Pulls in Hacky fix for button position on cloned objects #801

@gfodor gfodor mentioned this pull request Feb 16, 2019
Merged
@buildsize
Copy link

buildsize bot commented Feb 16, 2019 •
edited
Loading

File name Previous Size New Size Change
avatar-selector.html 1004 bytes 1004 bytes 0 bytes (0%)
favicon.ico 33.69 KB 33.69 KB 0 bytes (0%)
hub-preview.png 16.5 KB 16.5 KB 0 bytes (0%)
hub.html 50.91 KB 50.91 KB 0 bytes (0%)
index.html 1.24 KB 1.24 KB 0 bytes (0%)
link.html 1.35 KB 1.35 KB 0 bytes (0%)
LoadingObject_Atom-[hash].glb 27.43 KB 27.43 KB 0 bytes (0%)
waternormals-[hash].jpg 242.98 KB 242.98 KB 0 bytes (0%)
bubble_off-[hash].png 4.22 KB 4.22 KB 0 bytes (0%)
bubble_off-hover-[hash].png 5.85 KB 5.85 KB 0 bytes (0%)
bubble_on-[hash].png 5.65 KB 5.65 KB 0 bytes (0%)
bubble_on-hover-[hash].png 5.46 KB 5.46 KB 0 bytes (0%)
create_object-[hash].png 8.38 KB 8.38 KB 0 bytes (0%)
create_object-hover-[hash].png 10.65 KB 10.65 KB 0 bytes (0%)
freeze_off-[hash].png 7.53 KB 7.53 KB 0 bytes (0%)
freeze_off-hover-[hash].png 9.96 KB 9.96 KB 0 bytes (0%)
freeze_on-[hash].png 7.36 KB 7.36 KB 0 bytes (0%)
freeze_on-hover-[hash].png 9.45 KB 9.45 KB 0 bytes (0%)
mute_off-[hash].png 2.76 KB 2.76 KB 0 bytes (0%)
mute_off-hover-[hash].png 3.65 KB 3.65 KB 0 bytes (0%)
mute_on-[hash].png 5.48 KB 5.48 KB 0 bytes (0%)
mute_on-hover-[hash].png 5.29 KB 5.29 KB 0 bytes (0%)
spawn_photo-[hash].png 3.14 KB 3.14 KB 0 bytes (0%)
tooltip.9-[hash].png 640 bytes 640 bytes 0 bytes (0%)
account-[hash].svg 826 bytes 826 bytes 0 bytes (0%)
daydream_entry-[hash].svg 6.47 KB 6.47 KB 0 bytes (0%)
default_thumbnail-[hash].png 3.02 KB 3.02 KB 0 bytes (0%)
desktop_screen_entry-[hash].svg 376 bytes 376 bytes 0 bytes (0%)
device_entry-[hash].svg 10.48 KB 10.48 KB 0 bytes (0%)
dropdown_arrow-[hash].png 172 bytes 172 bytes 0 bytes (0%)
dropdown_arrow@2x-[hash].png 233 bytes 233 bytes 0 bytes (0%)
gearvr_entry-[hash].svg 574 bytes 574 bytes 0 bytes (0%)
generic_vr_entry-[hash].svg 952 bytes 952 bytes 0 bytes (0%)
giphy_logo-[hash].png 1.02 KB 1.02 KB 0 bytes (0%)
level_background-[hash].png 4.03 KB 4.03 KB 0 bytes (0%)
level_background@2x-[hash].png 4.63 KB 4.63 KB 0 bytes (0%)
level_fill-[hash].png 1.03 KB 1.03 KB 0 bytes (0%)
level_fill@2x-[hash].png 2.02 KB 2.02 KB 0 bytes (0%)
logo-[hash].svg 14.21 KB 14.21 KB 0 bytes (0%)
mic_denied-[hash].png 2.02 KB 2.02 KB 0 bytes (0%)
mic_denied@2x-[hash].png 3.97 KB 3.97 KB 0 bytes (0%)
mic_granted-[hash].png 2.21 KB 2.21 KB 0 bytes (0%)
mic_granted@2x-[hash].png 4.26 KB 4.26 KB 0 bytes (0%)
mic_level-[hash].png 697 bytes 697 bytes 0 bytes (0%)
mic_level@2x-[hash].png 1.48 KB 1.48 KB 0 bytes (0%)
mic_small-[hash].png 234 bytes 234 bytes 0 bytes (0%)
mic_small@2x-[hash].png 370 bytes 370 bytes 0 bytes (0%)
mobile_screen_entry-[hash].svg 914 bytes 914 bytes 0 bytes (0%)
speaker_level-[hash].png 626 bytes 626 bytes 0 bytes (0%)
speaker_level@2x-[hash].png 1.29 KB 1.29 KB 0 bytes (0%)
warning_icon-[hash].png 442 bytes 442 bytes 0 bytes (0%)
warning_icon@2x-[hash].png 699 bytes 699 bytes 0 bytes (0%)
aframe-inspector.min-[hash].js 384.44 KB 384.44 KB 0 bytes (0%)
avatar-selector-[hash].js 60.6 KB 60.6 KB 0 bytes (0%)
avatar-selector-[hash].js.map 148.97 KB 148.97 KB 0 bytes (0%)
engine-[hash].js 1.25 MB 1.25 MB 0 bytes (0%)
engine-[hash].js.map 4.02 MB 4.02 MB 0 bytes (0%)
gifparsing.worker-[hash].js 1.92 KB 1.92 KB 0 bytes (0%)
gifparsing.worker-[hash].js.map 8.33 KB 8.33 KB 0 bytes (0%)
hub-[hash].js 492.58 KB 492.83 KB 252 bytes (0%)
hub-[hash].js.map 1.26 MB 1.26 MB 1.41 KB (0%)
index-[hash].js 57.06 KB 57.06 KB 0 bytes (0%)
index-[hash].js.map 116.61 KB 116.61 KB 0 bytes (0%)
link-[hash].js 36.09 KB 36.09 KB 0 bytes (0%)
link-[hash].js.map 82.22 KB 82.22 KB 0 bytes (0%)
sketchfab-zip.worker-[hash].js 155.05 KB 155.05 KB 0 bytes (0%)
sketchfab-zip.worker-[hash].js.map 774.31 KB 774.31 KB 0 bytes (0%)
vendor-[hash].js 1.26 MB 1.26 MB 0 bytes (0%)
vendor-[hash].js.map 4.49 MB 4.49 MB 0 bytes (0%)
quack-[hash].mp3 7.03 KB 7.03 KB 0 bytes (0%)
specialquack-[hash].mp3 11.57 KB 11.57 KB 0 bytes (0%)
tone-[hash].mp3 53.92 KB 53.92 KB 0 bytes (0%)
tone-[hash].wav 385.29 KB 385.29 KB 0 bytes (0%)
tone-[hash].webm 32.04 KB 32.04 KB 0 bytes (0%)
tone-[hash].ogg 32.55 KB 32.55 KB 0 bytes (0%)
avatar-selector-[hash].css 1.15 KB 1.15 KB 0 bytes (0%)
avatar-selector-[hash].css.map 136 bytes 136 bytes 0 bytes (0%)
hub-[hash].css 98.5 KB 98.5 KB 0 bytes (0%)
hub-[hash].css.map 124 bytes 124 bytes 0 bytes (0%)
index-[hash].css 42.39 KB 42.39 KB 0 bytes (0%)
index-[hash].css.map 126 bytes 126 bytes 0 bytes (0%)
link-[hash].css 6.1 KB 6.1 KB 0 bytes (0%)
link-[hash].css.map 125 bytes 125 bytes 0 bytes (0%)
home-[hash].mp4 2 MB 2 MB 0 bytes (0%)
home-[hash].webm 1.81 MB 1.81 MB 0 bytes (0%)
negx-[hash].jpg 54.45 KB 54.45 KB 0 bytes (0%)
negy-[hash].jpg 50.97 KB 50.97 KB 0 bytes (0%)
negz-[hash].jpg 53.29 KB 53.29 KB 0 bytes (0%)
posx-[hash].jpg 58.64 KB 58.64 KB 0 bytes (0%)
posy-[hash].jpg 19.17 KB 19.17 KB 0 bytes (0%)
posz-[hash].jpg 57.49 KB 57.49 KB 0 bytes (0%)
spawn_pen-[hash].png 2.39 KB 2.39 KB 0 bytes (0%)
spawn_pen-hover-[hash].png 3.07 KB 3.07 KB 0 bytes (0%)
spawn_camera-[hash].png 3.27 KB 3.27 KB 0 bytes (0%)
spawn_camera-hover-[hash].png 3.75 KB 3.75 KB 0 bytes (0%)
scene.html 2.56 KB 2.56 KB 0 bytes (0%)
scene-[hash].js 125.13 KB 125.13 KB 0 bytes (0%)
scene-[hash].js.map 309.71 KB 309.71 KB 0 bytes (0%)
scene-[hash].css 10.91 KB 10.91 KB 0 bytes (0%)
scene-[hash].css.map 126 bytes 126 bytes 0 bytes (0%)
camera_tool-[hash].glb 757.23 KB 757.23 KB 0 bytes (0%)
hub-preview-white-[hash].png 62.76 KB 62.76 KB 0 bytes (0%)
link_dialog_header-[hash].svg 950 bytes 950 bytes 0 bytes (0%)
moz-logo-black-[hash].png 1.71 KB 1.71 KB 0 bytes (0%)
hub-preview-light-no-shadow-[hash].png 9.35 KB 9.35 KB 0 bytes (0%)
spoke.html 1.98 KB 1.98 KB 0 bytes (0%)
spoke-[hash].js 18.06 KB 18.06 KB 0 bytes (0%)
spoke-[hash].js.map 29.04 KB 29.04 KB 0 bytes (0%)
spoke-[hash].css 6.32 KB 6.32 KB 0 bytes (0%)
spoke-[hash].css.map 126 bytes 126 bytes 0 bytes (0%)
spoke_logo-[hash].png 128.43 KB 128.43 KB 0 bytes (0%)
spoke_logo_black-[hash].png 39.54 KB 39.54 KB 0 bytes (0%)
twitter-[hash].svg 869 bytes 869 bytes 0 bytes (0%)
presence_desktop-[hash].png 199 bytes 199 bytes 0 bytes (0%)
presence_phone-[hash].png 209 bytes 209 bytes 0 bytes (0%)
presence_vr-[hash].png 469 bytes 469 bytes 0 bytes (0%)
hub.service.js 1.34 KB 1.34 KB 0 bytes (0%)
spoke-[hash].webm 5.52 MB 5.52 MB 0 bytes (0%)
spoke-[hash].mp4 6.27 MB 6.27 MB 0 bytes (0%)
action_button.9-[hash].png 1.11 KB 1.11 KB 0 bytes (0%)
spawn_message-[hash].png 493 bytes 493 bytes 0 bytes (0%)
share_camera_off-[hash].png 2.67 KB 2.67 KB 0 bytes (0%)
share_camera_on-[hash].png 4.42 KB 4.42 KB 0 bytes (0%)
share_camera_on-hover-[hash].png 2.8 KB 2.8 KB 0 bytes (0%)
share_screen_off-[hash].png 2.79 KB 2.79 KB 0 bytes (0%)
share_screen_on-[hash].png 4.54 KB 4.54 KB 0 bytes (0%)
share_screen_on-hover-[hash].png 4.42 KB 4.42 KB 0 bytes (0%)
share_window_off-[hash].png 2.79 KB 2.79 KB 0 bytes (0%)
share_window_on-[hash].png 4.52 KB 4.52 KB 0 bytes (0%)
share_window_on-hover-[hash].png 4.38 KB 4.38 KB 0 bytes (0%)
share_message-[hash].png 17.46 KB 17.46 KB 0 bytes (0%)
presence-count-[hash].png 1.27 KB 1.27 KB 0 bytes (0%)
whats-new.html 1.27 KB 1.27 KB 0 bytes (0%)
whats-new-[hash].js 50.96 KB 50.96 KB 0 bytes (0%)
whats-new-[hash].js.map 242.19 KB 242.19 KB 0 bytes (0%)
whats-new-[hash].css 2.75 KB 2.75 KB 0 bytes (0%)
whats-new-[hash].css.map 130 bytes 130 bytes 0 bytes (0%)
generic_vr_headset-[hash].svg 950 bytes 950 bytes 0 bytes (0%)
pause-[hash].png 6.58 KB 6.58 KB 0 bytes (0%)
pause-hover-[hash].png 6.89 KB 6.89 KB 0 bytes (0%)
play-[hash].png 6.29 KB 6.29 KB 0 bytes (0%)
play-hover-[hash].png 6.62 KB 6.62 KB 0 bytes (0%)
seek_back-[hash].png 3.69 KB 3.69 KB 0 bytes (0%)
seek_back-hover-[hash].png 3.99 KB 3.99 KB 0 bytes (0%)
seek_fwd-[hash].png 3.73 KB 3.73 KB 0 bytes (0%)
seek_fwd-hover-[hash].png 4.09 KB 4.09 KB 0 bytes (0%)
rotation-[hash].png 2.27 KB 2.27 KB 0 bytes (0%)
admin.html 1.41 KB 1.41 KB 0 bytes (0%)
admin-[hash].js 43.1 KB 43.1 KB 0 bytes (0%)
admin-[hash].js.map 111.84 KB 111.84 KB 0 bytes (0%)
admin-[hash].css 58 bytes 58 bytes 0 bytes (0%)
admin-[hash].css.map 126 bytes 126 bytes 0 bytes (0%)
admindeps-[hash].js 773.82 KB 773.82 KB 0 bytes (0%)
admindeps-[hash].js.map 2.93 MB 2.93 MB 3 bytes (0%)
engine-[hash].css 11.3 KB 11.3 KB 0 bytes (0%)
engine-[hash].css.map 127 bytes 127 bytes 0 bytes (0%)
home-hero-background-[hash].jpg 27.47 KB 27.47 KB 0 bytes (0%)
A_bendUp-[hash].mp3 5.16 KB 5.16 KB 0 bytes (0%)
Eb_blip-[hash].mp3 1.25 KB 1.25 KB 0 bytes (0%)
PenDraw1-[hash].mp3 1.91 KB 1.91 KB 0 bytes (0%)
PenSpawn-[hash].mp3 2.8 KB 2.8 KB 0 bytes (0%)
PicSnapHey-[hash].mp3 6.5 KB 6.5 KB 0 bytes (0%)
pop-[hash].mp3 5.77 KB 5.77 KB 0 bytes (0%)
quickTurn-[hash].mp3 1.96 KB 1.96 KB 0 bytes (0%)
suspense-[hash].mp3 23.87 KB 23.87 KB 0 bytes (0%)
tack-[hash].mp3 2.52 KB 2.52 KB 0 bytes (0%)
tap_mellow-[hash].mp3 1.12 KB 1.12 KB 0 bytes (0%)
teleportArc-[hash].mp3 9.25 KB 9.25 KB 0 bytes (0%)
tick-[hash].mp3 1.42 KB 1.42 KB 0 bytes (0%)
welcome-[hash].mp3 25.17 KB 25.17 KB 0 bytes (0%)

johnshaughnessy
johnshaughnessy reviewed Feb 20, 2019
View reviewed changes
Copy link
Contributor

@johnshaughnessy johnshaughnessy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍 -- I think position-at-box-shape-border can be written simpler. I remember thinking the same thing when first writing it. Feels clunky to me.

@gfodor gfodor merged commit 0dc4659 into master Feb 20, 2019
@MarcelRaschke MarcelRaschke mentioned this pull request Aug 19, 2022
Open
@snyk-bot snyk-bot mentioned this pull request Aug 19, 2022
Open
@MarcelRaschke MarcelRaschke mentioned this pull request Aug 20, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnshaughnessy johnshaughnessy johnshaughnessy left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gfodor @johnshaughnessy @netpro2k