Fix iOS HLS issues (probably) #835
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
netpro2k
commented
Jan 12, 2019
| @@ -174,7 +163,7 @@ function createVideoTexture(url, contentType) { | |||
| videoEl.onerror = reject; | |||
| } | |||
|
|
|||
| videoEl.addEventListener("loadedmetadata", () => resolve(texture), { once: true }); | |||
| videoEl.addEventListener("canplay", () => resolve(texture), { once: true }); | |||
There was a problem hiding this comment.
Video size was not set yet when the loadedmetadata event fired for HLS videos. This is probably a more "correct" event for us to wait on for everything anyway
netpro2k
commented
Jan 12, 2019
| @@ -156,16 +155,6 @@ function createVideoTexture(url, contentType) { | |||
| } else if (videoEl.canPlayType(contentType)) { | |||
| videoEl.src = url; | |||
| videoEl.onerror = reject; | |||
|
|
|||
| // HACK aframe iOS HLS video hacks | |||
| if (isIOS) { | |||
There was a problem hiding this comment.
Looks like these hacks only break things, and things seem fine without them or any sort of special shader. Chalk it up to iOS updates?
There was a problem hiding this comment.
down with the HACK
netpro2k
commented
Jan 12, 2019
| @@ -499,13 +493,12 @@ AFRAME.registerComponent("media-video", { | |||
| if (texture.hls.currentLevel >= 0) { | |||
| updateLiveState(); | |||
| } | |||
| } else { | |||
| this.videoIsLive = this.video.duration === Infinity; | |||
There was a problem hiding this comment.
No clue if this is actually going to work, but I can't get a streaming source to work locally to try it out.
This was referenced Nov 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix video aspect ratio being broken, fix video being flipped, and an attempted fix for detecting live/VOD state (though I was not able to test this locally).