feat: "See Plans" CTA for demo room #6154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
NOTE: This component has very specific styling and composition, hence the new component rather than the existing Lilypad button. If we decide to use this styling further, I can create a BrandButton component specific for this use in Lilypad. |
nickgrato
reviewed
Jul 5, 2023
| & > * { | ||
| margin-right: 24px; | ||
| } | ||
| :local(.centerContent) { |
There was a problem hiding this comment.
if you can somehow get rid of the camelCase here that would be awesome. If it's baked in, no big.
nickgrato
reviewed
Jul 5, 2023
| @@ -19,12 +27,12 @@ function MoreMenuItem({ item, closePopover }) { | |||
| target={item.target || "_blank"} | |||
| rel="noopener noreferrer" | |||
| > | |||
| <Icon /> | |||
| {item.icon?.src ? <img src={item.icon.src} alt={imageAltText} /> : <Icon />} | |||
There was a problem hiding this comment.
can you move this logic to line 11? Then you could leave both of these as "Icon" and on line 11 it gets assigned the right asset?
nickgrato
reviewed
Jul 5, 2023
| color: var(--color-interaction-primary); | ||
| width: fit-content; | ||
| min-width: 132px; | ||
| font-size: 14px; |
There was a problem hiding this comment.
are all the font sixes "px" in the project?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Demo room CTA to redirect to https://hubs.mozilla.com/#subscribe
As per designs.