Set load and clear chat command. #6089
Conversation
src/message-dispatch.js
Outdated
| case "clear": | ||
| { | ||
| if (APP.hubChannel.can("pin_objects") && APP.hubChannel.signIn) { | ||
| clearState(this.hubChannel); |
There was a problem hiding this comment.
It's strange to see APP.hubChannel on the line above and this.hubChannel on this line. They refer to the same object. Use this.hubChannel on both lines.
There was a problem hiding this comment.
I just pushed this change.
src/utils/entity-state-utils.ts
Outdated
| export function clearState(hubChannel: HubChannel) { | ||
| networkedQuery(APP.world).forEach(eid => { | ||
| if (isNetworkInstantiated(eid) && isPinned(eid)) { | ||
| deleteTheDeletableAncestor(APP.world, eid); |
There was a problem hiding this comment.
Pass world: HubsWorld into clearState and loadState as an argument, rather than pulling it off the APP global. We are inconsistent at doing this, so you'll see it done both ways, but generally speaking, direct use of the global is to be avoided.
In this case, it doesn't make much of a difference -- we simply pass the access up one layer (to message-dispatch), but it's happening there already so it's not another new place we're going against the grain.
There was a problem hiding this comment.
I was able to make this change as well.
Why:
We wanted to create a chat command to enable the QA team to load bulk assets for testing.
I have wrapped both with a condition where sign-in and admin permissions are needed.