tidying up security issues for locked down demo #6051
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keianhzo
reviewed
Apr 26, 2023
Comment on lines
5
to
+6
| if (!scene.is("entered")) return; | ||
| if (userinput.get(paths.actions.startInspectingSelf)) { | ||
| if (userinput.get(paths.actions.startInspectingSelf) && !isLockedDownDemoRoom()) { |
There was a problem hiding this comment.
Another option would have been to early exit as we do with the enter scene condition:
if (!scene.is("entered") || isLockedDownDemoRoom()) return;
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR locks down the "i" key shortcut in locked down demo rooms and allows promoted users to have full access to room features. The desire is for promoted users to be able to moderate demo rooms.