Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Locked down demo mvp #6030
Locked down demo mvp #6030
Changes from 5 commits
9445a97
6af2025
d0cf86d
2e3cf7d
ed55db1
b8f775f
0630f2d
91617df
0e53989
a87f4b9
4a051ec
bb519e9
152d569
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking at this again, I don't think this is avoiding an avatar update. This is called by the
avatar.js
page and there we don't have any context about the currenthub_id
. We just update the store and that event is recived in any other open document that is using the same local storage origin.It seems that we are processing that here:
https://github.com/mozilla/hubs/blob/b8f775f10da2fdd2b9515adc992050ca7c3cf986/src/scene-entry-manager.js#L180
And there we can correctly get the
hub_id
so I think we can revert the changes here and add that logic there.