Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Log theme when updated in preferences #6027

Merged
merged 2 commits into from
Apr 11, 2023
Merged

Log theme when updated in preferences #6027

merged 2 commits into from
Apr 11, 2023

Conversation

nikk15
Copy link
Contributor

@nikk15 nikk15 commented Apr 10, 2023

  • Log the value of theme when updated in Preferences. eg "Theme updated to: Browser Default"

@nikk15 nikk15 temporarily deployed to smoke April 10, 2023 20:34 — with GitHub Actions Inactive
nickgrato
nickgrato approved these changes Apr 11, 2023
View reviewed changes
Copy link
Contributor

@nickgrato nickgrato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice test

@nikk15 nikk15 merged commit 6e48abe into master Apr 11, 2023
@nikk15 nikk15 deleted the log-preferred-theme-change branch April 11, 2023 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shasha199 shasha199 shasha199 approved these changes

@nickgrato nickgrato nickgrato approved these changes

@keianhzo keianhzo Awaiting requested review from keianhzo

@johnshaughnessy johnshaughnessy Awaiting requested review from johnshaughnessy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nikk15 @nickgrato @shasha199