Replace deprecated prettier eslint integration with the vscode plugin #5822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keianhzo
force-pushed
the
vscode-eslint
branch
from
dd9a80f
to
9e53c6c
Compare
| // Use 'prettier-eslint' instead of 'prettier'. Other settings will only be fallbacks in case they could not be inferred from eslint rules. | ||
| "prettier.eslintIntegration": true, | ||
| // Using the prettier-vscode plugin as the old eslint integration has been deprecated. More here: https://github.com/prettier/prettier-vscode/issues/870 | ||
| "editor.defaultFormatter": "esbenp.prettier-vscode", |
There was a problem hiding this comment.
Is this configuration specifically for vs code users?
There was a problem hiding this comment.
I believe everything under the .vscode/ folder is only applied by VSCode (maybe also some compatible forks?) But it should not affect other editors unless they purposefully read that file.
nickgrato
approved these changes
Dec 8, 2022
There was a problem hiding this comment.
This looks good to me, I think the only thing ( and this could be a big change ) that I would change is the actual prettier file that this references.
I have these in Subscriptions and Marketing project, some of these might be default and unnecessary.
{
"singleQuote": true,
"jsxSingleQuote": false,
"tabWidth": 2,
"semi": true
}
Been a heavy adopter of single quotes in Javascript and double quotes in HMTL/JSX however.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The prettier eslint integration has been deprecated so in VSCode we are falling back to the default formatter on save that doesn't follow the same rules as the ones defined in eslintrc.
This only affect people using VSCode.
Read more here: prettier/prettier-vscode#870