-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pinning, networking, and waypoints #5815
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnshaughnessy
force-pushed
the
feature/waypoints-2
branch
from
November 24, 2022 19:48
8aac581
to
222d421
Compare
johnshaughnessy
force-pushed
the
feature/networking-system-refactor
branch
from
November 24, 2022 20:07
9efaaa2
to
b93c5ae
Compare
johnshaughnessy
force-pushed
the
feature/waypoints-2
branch
2 times, most recently
from
November 24, 2022 20:09
fadc0c7
to
f0a2a17
Compare
Base automatically changed from
feature/networking-system-refactor
to
master
November 25, 2022 18:10
johnshaughnessy
force-pushed
the
feature/waypoints-2
branch
from
November 25, 2022 18:44
0a30dbe
to
98b91b3
Compare
johnshaughnessy
force-pushed
the
feature/waypoints-2
branch
from
November 28, 2022 21:29
98b91b3
to
e05413f
Compare
johnshaughnessy
force-pushed
the
feature/waypoints-2
branch
from
November 30, 2022 02:32
e05413f
to
1280700
Compare
johnshaughnessy
force-pushed
the
feature/waypoints-2
branch
2 times, most recently
from
December 1, 2022 03:59
8b4b0ba
to
554bcab
Compare
johnshaughnessy
force-pushed
the
feature/waypoints-2
branch
from
December 2, 2022 15:54
c57703a
to
996ef29
Compare
johnshaughnessy
force-pushed
the
feature/waypoints-2
branch
from
December 3, 2022 05:04
bd9b930
to
8cf139e
Compare
Proof of concept. Only works if all clients use newLoader
This needs to be part of initial data for the media prefab so that pinned objects load correctly
johnshaughnessy
force-pushed
the
feature/waypoints-2
branch
from
January 11, 2023 01:36
78c057f
to
e9a9226
Compare
johnshaughnessy
had a problem deploying
to
hc-bio
January 11, 2023 01:43 — with
GitHub Actions
Failure
johnshaughnessy
had a problem deploying
to
hc-bio
January 11, 2023 15:59 — with
GitHub Actions
Failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes changes to the networking system to support waypoints. It re-imagines pinning for new-netcode objects, but the actual calls to the backend are disabled until we write some reticulum code to separate new writes from existing room objects. It also makes some necessary tweaks to media frames and reimplements waypoints.