New tooltips #5805
Merged
New tooltips #5805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
netpro2k
reviewed
Dec 2, 2022
There was a problem hiding this comment.
The new tips look a whole lot nicer than the old ones! I made a few practical comments, namely that we need to double check we aren't trouncing existing translations and making sure we don't show tips to people who have already gone through the old flow.
Made some other comments on code structure, namely I think the control flow could be significantly simplified, especially if we loosen the old requirements which I bet we don't particularly care about anymore. Up to you if this is something you want to tackle now or we just want to get this out as is (seems to work, so ¯_ (ツ)_/¯.
keianhzo
force-pushed
the
new-tooltips
branch
from
74da4ae to
50dc8bd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for the new Tooltips design. The design can be checked here: