"Fix" scene page #5796
Merged
"Fix" scene page #5796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnshaughnessy
force-pushed
the
bug/scene-page
branch
from
efead0d
to
5f165e6
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#5793 introduced a regression that caused the scene page to fail to load.
This PR stops the scene page from loading the gltf file of the scene and shows the screenshot instead. It also makes scene-loading.ts not import all of hub.js, since scene-loading.ts is imported on the scene page and we don't want everything connected to hub.js to run.
We'll need to revisit the scene page in the future but this at least shows the screenshot instead of a blank page.