Feat/record mode #5718
Merged
Feat/record mode #5718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
> > Co-authored-by: Matt Cool <[email protected]>
Co-authored-by:[email protected] Co-authored-by:[email protected]
As I mentioned at the collaborative hacking session on Saturday, here is some code to make the cursor invisible without changing the scale. While there isn't much difference in the end result, I do want to note that with the scaling method, the cursor will show up again when it hovers over an object, but making it invisible will keep it hidden (the blue flashing glow is present with both methods).
Make cursor invisible instead of scaling
add toast notification for record mode
netpro2k
reviewed
Oct 31, 2022
|
Actually it looks like this now has some merge conflicts. I suspect its from the changes made with chat/mic/moderation. |
|
@netpro2k it should be resolved now and ready to merge if everything looks good to you! |
|
Tested locally without issues. lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR looks to solve a pain for folks trying to do screen captures in Hubs.
Currently, we have a hide ui function but it fails to hide the cursor, debug menus and is not accessible on non-QWRTY keyboards.
Additionally it's annoying to have to close the hide ui tip manually each time you want to record.
This solution addresses all of the previously mentioned problems and provides a smooth transition to a state suitable for recording.
Alternate solutions we considered:
we thought about hiding nametags as well but decided to leave that up to the user.
we considered different inputs on the off chance a user presses the key by mistake. We decided 'R' was too close to movement keys.
we thought about using the built in toast messages but this got tricky since we were also using the built in functions for hide UI
record.mp4