Fix embed codes for anonymous users or non-owners #5623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brianpeiris
commented
Jul 28, 2022
| @@ -556,8 +547,7 @@ function handleHubChannelJoined(entryManager, hubChannel, messageDispatch, data, | |||
| onMediaSearchResultEntrySelected: (entry, selectAction) => | |||
| scene.emit("action_selected_media_result_entry", { entry, selectAction }), | |||
| onMediaSearchCancelled: entry => scene.emit("action_media_search_cancelled", entry), | |||
| onAvatarSaved: entry => scene.emit("action_avatar_saved", entry), | |||
| embedToken: embedToken | |||
There was a problem hiding this comment.
The embedToken prop was a remnant from older an UI design. It is no longer used in UIRoot.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a user is not signed in and they create a room, we store the embed token for the room in the local store. We had some code that retrieved it from the store, but that code wasn't actually in use. This resulted in the embed token being null in the embed code.
Additionally, if a user is not an owner of a room, they will not have an embed token for the room, by design. In those cases, we should hide the embed code UI altogether.
Fixes #5622 Fixes #3570