Fix issue switching between scenes with many entities #5605
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When switching between scenes with > 100 entities (which is not even all that many) BitECS's entity id recycling causes some strange behavior in our object3d cleanup code.
This PR (along with a patch to BitECS) allows entity id recycling to be configured, and configures it to 20% of our 10,000 entity max (2000). This points at our own fork of BitECS for now until the change lands upstream. This is still only a partial solution, as the issue would still happen if entities are added on a frame where > 2000 entities were also removed, but this is very unlikely to happen.
There was some discussion of further solutions on github and discord