Hubstrky 446 #5538
Merged
Hubstrky 446 #5538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 29, 2022 10:10
brianpeiris
approved these changes
Jun 29, 2022
| const onload = resp => { | ||
| // Check Target Status | ||
| const status = resp.target.status; | ||
| if (status !== 200 || status > 300 || status < 200) { |
There was a problem hiding this comment.
The other comparisons are redundant if you're going to error on !== 200 anyway.
Suggested change
| if (status !== 200 || status > 300 || status < 200) { | |
| if (status !== 200) { |
brianpeiris
reviewed
Jun 30, 2022
| </h3> | ||
| <p className={styles.message_body}> | ||
| <FormattedMessage | ||
| defaultMessage="Keep an eye out for product updates and an invite to join us as a tester in August." |
There was a problem hiding this comment.
Talked with @emclaren - can we drop "in August" and just go "Keep an eye out for product updates and an invite to join us as a tester"?
brianpeiris
approved these changes
Jun 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira ticket 446
Adding Banner for email sign up for MVP2 launch