Detect iPadOS as iOS #4700
Merged
Detect iPadOS as iOS #4700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use A-Frame's
iOS()to detect iOS. It seems to check ifnavigator.platformincludes "iPad", "iPhone", or "iPod".But on iPad
navigator.platform(ornavigator.userAgent) no longer include such words. Then workarounds patches for iOS in Hubs Client is no longer applied to iPad.Now iPad runs on iPadOS which is separated from iOS. But I speculate the inside of iPadOS and iOS should be very similar and we should apply the workarounds for iOS to iPad.
iPad detection code is from https://stackoverflow.com/questions/57776001/how-to-detect-ipad-pro-as-ipad-using-javascript looks usable Currently there doesn't seem to be easy and clear way to detect iOS.
Currently Hubs seems to have issues that videos don't play smoothly and audio from videos doesn't come out on iPad. I confirmed they are resolved with this PR.
Maybe this PR can fix #2035