Add proper FxR check #468
Merged
Add proper FxR check #468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cvan
suggested changes
Jul 20, 2018
src/utils/vr-caps-detect.js
Outdated
|
|
||
| // This needs to be kept up-to-date with the latest browsers that can support VR and Hubs. | ||
| // Checking for navigator.getVRDisplays always passes b/c of polyfill. | ||
| const isWebVRCapableBrowser = window.hasNativeWebVRImplementation; | ||
| const isFirefoxReality = "buildID" in navigator && isWebVRCapableBrowser; |
There was a problem hiding this comment.
there you go:
const isFirefoxReality = window.orientation === 0 && ("buildID" in navigator) && isWebVRCapableBrowser;
This was referenced Nov 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My speculative FxR check is wrong since we are using the Fennec UA. This seems like a sane check but wanted to make sure I wasn't missing something.
To be clear, we are not using user agent checks to determine device capabilities -- we're using them to determine if the user is currently already in a HMD. My understanding is there's no other way to do this right now.