change avatar preview background to background theme color #4666
Conversation
|
I don't mean to block a small change like this, but can we get some design input on it? IMO, I think the background served a specific purpose -- it indicated that the avatar preview area was separate from the panel, and indicated an interaction affordance, so that users had a hint that the avatar preview was live and that you could rotate the avatar. For dark mode, I would rather us use a slightly darker shade or slightly lighter shade, to differentiate it from the background. |
It's a good point and valid concern, how about using background3 instead? Matt and I also came to this conclusion. |
|
That sounds better, though I wish we gave our theme colors semantic names instead of 1, 2, 3, but that's a separate issue. |
Adds a function to avatar-preview.js that checks for a theme background color (must be hex value) and updates the preview background to that color. Default preview background will remain the same for now.
Putting the Avatar in a generic 'blueprint room' scene may be a better option than using a color there as we can still have contrast issues since the color of the avatar is variable.
For now this PR is meant to bring us one step closer to 'acceptable dark mode'.
Random theme:
Default:
