Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix audio mode command. Disable panner nodes in safari. #4594

Merged
merged 4 commits into from
Sep 1, 2021

Conversation

johnshaughnessy
Copy link
Contributor

@johnshaughnessy johnshaughnessy commented Sep 1, 2021

Fix the /audiomode command. Disable panner nodes in safari because of #4411 (comment)

These could have been two separate PR's if I were a little more disciplined. They don't have very much to do with each other.

@takahirox
Copy link
Contributor

I confirmed that Positional audio is disabled and /audiomode command has no effect on my Safari with this change. And also confirmed no distorted audio on Safari described in #4411.

@johnshaughnessy johnshaughnessy marked this pull request as ready for review September 1, 2021 23:03
@johnshaughnessy johnshaughnessy changed the title Bug/audio mode Fix audio mode. Disable panner nodes in safari. Sep 1, 2021
@johnshaughnessy johnshaughnessy merged commit 4d5fd3c into master Sep 1, 2021
@johnshaughnessy johnshaughnessy deleted the bug/audio-mode branch September 1, 2021 23:26
@johnshaughnessy johnshaughnessy changed the title Fix audio mode. Disable panner nodes in safari. Fix audio mode command. Disable panner nodes in safari. Sep 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants