Fix media-video audioSrc set up in media-loader #4576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks
audioSrcattribute inmedia-videoshould be non-empty only if video and audio tracks are separated (eg. 360 video). Butmedia-loaderseems to always set non-empty to it. This PR fixes the problem by setting upaudioSrconly when necessary. And I added some comments about it.Benefits:
media-videounnecessarily creates video and audio elements and does sync the states between them even for regular videos and audios. With this change, it will create only video element and the sync will no longer be needed. Good CPU and memory efficiency. And the logic will be simpler.