Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: object menu pin/unpin state #4544

Merged
merged 1 commit into from
Aug 24, 2021
Merged

Conversation

matthewbcool
Copy link
Contributor

@matthewbcool matthewbcool commented Aug 19, 2021

This fix resolves #4414

added a check to the usePinObject hook effect that sets the pinned state based on the value of getPinnedState()

cd10d77b5c2a137a95b8b91211c459a7.mp4

┆Issue is synchronized with this Jira Task

Copy link
Contributor

@johnshaughnessy johnshaughnessy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good find

@matthewbcool matthewbcool merged commit 727b2b2 into master Aug 24, 2021
@matthewbcool matthewbcool deleted the fix-object-menu-pin-state branch August 24, 2021 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The object menu wrongly displays the Pin/Un-pin button from the previous object after being changed
2 participants