Fix wrong transparent object menu buttons and texts #4470
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #4416 and #4417 by applying
alphaTest
toslice9
component and makingslice9
opaque for object menu buttons.The screenshot of this PR. Please compare with the ones in #4416 and #4417.
Currently
slice9
component doesn't havealphaTest
attribute so I made my fork.If this change looks good and we merge, I will make a PR to
slice9
component. When it will be merged, I will update package.json and package-lock.json.The mechanism of the problems
How to solve
slice9
component seems to be expected to be transparent because the component renders to the plane geometry mesh and uses alpha blend to cut off the four cornersalphaTest
attribute to theslice9
component and it resolves The around of the circled buttons in object menu can be weird #4417 because the four corner will be discorded in the shader and (my understanding is) the depth will not be written neither.slice9
components for the object menu opaque. In Three.js opaque objects are rendered earlier than transparent object. So the render order between texts (transparent) andslice9
(opaque) will be always correct and The contents of the buttons in object menu can be tranaparent #4416 will be fixed.Note
transparent
. So opaque texts can't be a solution unless we change the font.