Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force disable panner audio in safari #4441

Merged
merged 1 commit into from
Jul 23, 2021
Merged

Conversation

brianpeiris
Copy link
Contributor

No description provided.

@brianpeiris brianpeiris merged commit abe5909 into qa-stage Jul 23, 2021
@brianpeiris brianpeiris deleted the fix-safari-audio branch July 23, 2021 11:01
@robinkwilson robinkwilson restored the fix-safari-audio branch November 12, 2021 00:43
@brianpeiris
Copy link
Contributor Author

This was a hotfix for hubs-cloud that disabled panner audio in safari in order to avoid browser regressions that broke audio playback in rooms. (See #4411). This was merged into qa-test in #4442

These changes were specific to the hubs-cloud branch at the time, and were not merged into master, since the audio code in master had changed considerably at that point. The changes in this PR should be overridden by the current state of audio code in master.

@brianpeiris brianpeiris deleted the fix-safari-audio branch February 25, 2022 05:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant