-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added missing space to match PeopleSidebar #4333
Merged
johnshaughnessy
merged 6 commits into
Hubs-Foundation:master
from
LearnHub:people-missing-space
Sep 3, 2021
Merged
Added missing space to match PeopleSidebar #4333
johnshaughnessy
merged 6 commits into
Hubs-Foundation:master
from
LearnHub:people-missing-space
Sep 3, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haha, was bothering me too.
|
I agree with @yakyouk's suggestion. Either that or adding the space outside of the translated message. Otherwise all translation will need to remember to include this trailing space. |
# Conflicts: # src/react-components/room/ContentMenu.js
yakyouk
reviewed
Aug 10, 2021
johnshaughnessy
approved these changes
Sep 3, 2021
Softvision-GeluHaiduc
added
the
[QA]:Verified-fixed
Label for QA to mark verified fixed issues
label
Sep 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apologies for being pedantic, but it's been bothering me for a while.
┆Issue is synchronized with this Jira Task