-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lazy load media on scene entry #4135
Conversation
Nice work! Let me test soon later. One thing I talked with @netpro2k on Discord is there may be a chance that we need to change the loading cube effect because the current one may be annoying to users if there a lot of loading cubes in a viewport especially if media objects are big. This situation can happen on entry with this change. |
One more thing. Do you think there is a use case that scene owner wants to disable lazy load on room entry, meaning the owner wants users to enter a room when all the assets are ready? (eg. Artistic purpose.) If so we may add an option to disable it in scene settings or somewhere else. And for the automatic performance test I have been working on, I may want a capability to disable it or an event which is fired on all the assets are ready. |
1a7e226
to
d0e757c
Compare
@takahirox I've updated to enable/disable that through an admin config feature "Lazy load media". You should be able to override that from a script doing a Regarding the loading cube, if you both agree I'd rather consulting that with DPX and opening another issue to replace it in case they consider that's necessary, otherwise we might be blocking this for too long. |
Thanks for the update. Just in case I would like to know if other devs agree Opening another issue for loading cube effect sounds good to me. I don't think I understand the scene entry flow so I would like other devs to review the code more deeply. (And I would like to check the user experience of the case where a lot of medias are in a room but I couldn't do yet due to lack of time..) |
Now that you mention that, it might be interesting to also allow set it in the room settings and not at an admin level. Maybe @dom has a better sense of what might be more useful. |
d0e757c
to
0af4277
Compare
I've rebased this and fixed a couple of issues:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This mostly lgtm.
The moving of didConnectToNetworkedScene
seems pretty fishy, it should be the reticulum connection and NAF adapter that have an opinion about this not dialog.
Also, it seems like this PR removes LoadingObject_Atom.glb ... That doesn't seem correct. Was there supposed to be a replacement? This would be a good time to grab the updated model from Jim.
Made a few minor comments on the react code, but those are mostly just informational.
@netpro2k Thanks for the review, there were a few thing that were wrong or not optimal. I've have updated with a few changes. |
eaf5dd0
to
b4525c4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes lgtm
Related #3565
This PR adds initial support for lazy loading media upon scene loading to avoid waiting for all the media to be loaded to enter the scene.
┆Issue is synchronized with this Jira Task