Safari mobile audiocontext suspended fix

[keianhzo]

Fixes #338 Hack for a Safari Mobile issue where unplugging/plugging headphones may leave the Audio context in a suspended state.

Based on this contribution from @vincentfretin: #338 (comment)

I couldn't test this on a physical device so iOS Safari testing is needed.

[keianhzo]

@vincentfretin This PR is based on a contribution of yours in case you want to take a look, review or test.

[vincentfretin]

I don't think you need to check for browser here. You should always add the this.audioContext.onstatechange listener. It's harmless for other browsers.

[keianhzo]

@vincentfretin I have removed the iOS specific check. Still can't test so if anybody can please do and report.

[vincentfretin]

Yes, better. I'll try to test that soon with #3944

[brianpeiris]

Only one minor comment. LGTM otherwise.

[vincentfretin]

Test on iPad with iOS 14.3

Scenario:

• insert jack on iPad, all is working fine
• unplug jack

With master:
Results: mic volume indicator doesn't work, we don't hear others (the head doesn't scale)

With this PR:
Results:

• mic volume indicator doesn't work, we don't hear others (the head doesn't scale)
• "Audio has been resumed" log shows up (instead of "Audio has been suspended, click somewhere in the room to resume the audio.", weird)
• I click and move in the scene
• "Audio has been resumed" log shows up, the mic volume works, I can hear others.

The changes works but with the wrong first message, weird.

[vincentfretin]

I don't know what going on with LogMessageType.audioSuspended why it doesn't show the correct message
If I replace
document.getElementById("avatar-rig").messageDispatch.log(LogMessageType.audioSuspended)
by for example
document.getElementById("avatar-rig").messageDispatch.log(LogMessageType.audioNormalizationNaN)
I see the "audioNormalization command needs a valid number parameter." message, so good.

[vincentfretin]

If I add a new message in const logMessages = defineMessages in ChatSidebar.js
I actually see this new message for both LogMessageType.audioSuspended and LogMessageType.audioResumed
so it seems that document.getElementById("avatar-rig").messageDispatch.log doesn't take into account the argument and just use the last message in the logMessages list.

[vincentfretin]

I quickly looked at src/message-dispatch.js I don't understand how the translation machinery works. So I'll let you look into this.

[keianhzo]

Thanks for the review @vincentfretin! Good catch, I was missing adding the messages to the LogMessageType object. I've added that and now it should be working fine.

[vincentfretin]

Yes! This is good now.

You can merge.

[keianhzo]

Great, I'll merge then. Thanks a lot for your support!