Fix personal space bubble opacity #3951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
netpro2k
approved these changes
Feb 24, 2021
| @@ -19,7 +19,8 @@ AFRAME.registerComponent("tags", { | |||
| isHoverMenuChild: { default: false }, | |||
| isStatic: { default: false }, | |||
| inspectable: { default: false }, | |||
| preventAudioBoost: { default: false } | |||
| preventAudioBoost: { default: false }, | |||
| ignoreSpaceBubble: { default: false } | |||
There was a problem hiding this comment.
Probably warants thinking through the product implications, so maybe we don't need it in this PR, but wonder if we should expose this to gltfs like
AFRAME.GLTFModelPlus.registerComponent("ignore-space-bubble", "tags", el => {
el.setAttribute("tags", { ignoreSpaceBubble: true });
});So people could make things in their avatars that ignore the space bubble effect.
There was a problem hiding this comment.
I think this could be abused and we probably want to keep it internal. Happy to have a separate discussion about this at a later point though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug where the personal space bubble would set the opacity/transparent property of an already transparent object when leaving it's bounds. It also improves the space bubble so that avatars with multiple meshes will turn transparent when entering their bounds. To do this without turning the ui transparent, I added a new tag
ignoreSpaceBubblethat can be applied to the root of objects that should not be affected by the space bubble.