Revert "Bump puppeteer from 1.3.0 to 1.13.0 in /scripts/bot" #3937
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertlong
deleted the
revert-2973-dependabot/npm_and_yarn/scripts/bot/puppeteer-1.13.0
branch
This was referenced Mar 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #2973
I tried updating puppeteer and tested locally and things seemed to work properly. However, upon pushing to our smoke-test server I noticed that it wasn't working. Turns out I hadn't properly installed the updated dependencies when testing locally.
I tried to debug, but couldn't find the source of the problem. The audio element continues to play in the bot, but on the remote end, it goes silent after 1-5 seconds. Something seems to have changed in the WebRTC stack.