-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
reexecute enableChromeAEC if network changed #3604
reexecute enableChromeAEC if network changed #3604
Conversation
Even with this fix in my app, a user reported to me that on Chrome macOS he saw the other participant avatar talking (so the audio-analyzer is working) but couldn't hear anything. I don't have much details about it... I'm wondering if the Audio object created in enableChromeAEC can be paused by the browser (when taking a Skype or Teams call like it's the case for Safari iOS) or any other event...
|
Please forget my last comment. The issue I was having is actually the enableChromeAEC function that is sometime not called because of my alreadyExecuting boolean. :D Sometimes the setTimeout 0 to execute the callback on next tick is not enough, the audioContext is not in the running state yet. |
@keianhzo I think we're ready to work towards merging this now pending a review. Thanks again @vincentfretin! |
Looks great, thanks a lot for this @vincentfretin! Now that we are doing retries for other RTC relates services it's great to have this aligned. I've just pointed out a couple of things. Let me know what your thoughts are. |
When the network change from wired to Wi-Fi, the RTCPeerConnection loopback stays disconnected, recreate it after 10s if it didn't get back to connected.
Note : this is only a partial fix. There is still an issue with the websocket and Send Transport that doesn't reconnect. It just stays disconnected on Chrome.