Use qsVREntryType as forcedVREntryType when remounting UI for mobileVR if it is available #3408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…R if it is available
takahirox
force-pushed
the
UseQsVREntryType
branch
from
a1bf3db
to
f217fd5
Compare
This was referenced Mar 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
I opened Hubs with
vr_entry_type=2d_nowfor automatic testing purpose because I want to shortcut the dialogs and automatically enter a room. But on VR headsets (I used Oculus Quest), the audio setup dialog is displayed.The reason seems that
forcedVREntryTypeis overridden with "vr" for mobileVR.https://github.com/mozilla/hubs/blob/9ea70d174202679da664904456866c5570a984c8/src/hub.js#L1065
Suggestion
I think using
qsVREntryTypeif it's available (forcedVREntryType: qsVREntryType || "vr") as it's done for non-mobileVR sounds reasonable.But I haven't followed all the related code yet. Please let me know if this change can cause any problems in certain scenarios.