fix icon for iOS Safari's "Add to Homescreen" (PWA): add required <link rel="apple-touch-icon"> tag (fixes issue #335)
#1557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ink rel="apple-touch-icon">` tag (fixes issue #335) Context: - Apple shipped support in [Safari for iOS 11.1](https://developer.apple.com/library/archive/releasenotes/General/WhatsNewInSafari/Articles/Safari_11_1.html#//apple_ref/doc/uid/TP40014305-CH14-SW6) for parsing [web-app manifests](https://w3c.github.io/manifest/) via `<link rel="manifest">` but (for some reason) ignores the `icons` defined in the manifest. A `<meta name="apple-touch-icon">` tag appears to be still required for the time being. (I assume that'll change in an upcoming release.) - This also replaces the icon of the scene pages, since A-Frame injects, if missing, [a few Apple-proprietary `<meta>` tags](https://github.com/aframevr/aframe/blob/c871d04e/src/core/scene/metaTags.js#L14-L16).
|
thanks for this! this had to get added to the reticulum side, so I did that here: https://github.com/mozilla/reticulum/pull/227/files |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see discussion: #335 (comment)
Context
<link rel="manifest">but (for some reason) ignores theiconsdefined in the manifest. A<meta name="apple-touch-icon">tag appears to be still required for the time being. (I assume that'll change in an upcoming release.)<meta>tags.