Feature/scale tool #1122
Closed
Feature/scale tool #1122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gfodor
commented
Mar 28, 2019
| } else { | ||
| v.set(0, 1, 0); | ||
| const scaleFactor = |
There was a problem hiding this comment.
This is the main new control flow, everything else here is just renames
Merged
johnshaughnessy
approved these changes
Mar 28, 2019
| @@ -16,12 +21,12 @@ const v2 = new THREE.Vector3(); | |||
| const q = new THREE.Quaternion(); | |||
| const q2 = new THREE.Quaternion(); | |||
|
|
|||
| AFRAME.registerComponent("rotate-button", { | |||
| AFRAME.registerComponent("xform-button", { | |||
There was a problem hiding this comment.
Would prefer transform to xform. We would have called xforms in the userinput system transforms or transformFunctions but we didn't want to risk confusion with the "position/rotation/scale" interpretation of "transform". Here that IS what we mean, so I think it fits better.
There was a problem hiding this comment.
ah good point. i was trying to save characters since this term is used in many places, but i agree the conflict with the user input concept makes it worth changing.
This was referenced Nov 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a scale tool to the menu and also renames the rotate components to
xformsince it is now used for scaling.