Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow skipping code paths relying upon webRTC #1111

Closed
wants to merge 1 commit into from
Closed

Allow skipping code paths relying upon webRTC #1111

wants to merge 1 commit into from

Conversation

gfodor
Copy link
Contributor

@gfodor gfodor commented Mar 26, 2019

This PR adds the skip_webrtc flag which can be used to bypass WebRTC/UserMedia API calls in the startup/entry flow of Hubs, so Hubs can be tested in Servo.

@gfodor gfodor requested a review from brianpeiris March 26, 2019 23:33
brianpeiris
brianpeiris reviewed Mar 27, 2019
View reviewed changes
Copy link
Contributor

@brianpeiris brianpeiris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed, these changes won't be sufficient to get hubs working in Servo, and I suspect we'll have to make more webrtc-related changes, in addition to fixing other blockers

@gfodor
Copy link
Contributor Author

gfodor commented Apr 5, 2019

Closing for now

@gfodor gfodor closed this Apr 5, 2019
@brianpeiris brianpeiris deleted the feature/non-webrtc-mode branch August 9, 2022 03:50
This was referenced Nov 4, 2022
Open
Open
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brianpeiris brianpeiris brianpeiris left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gfodor @brianpeiris