Waypoint link reloads room on first click

[johnshaughnessy]

Description
See #2983

To Reproduce
Steps to reproduce the behavior:

1. Go to '...'
2. Click on '....'
3. Scroll down to '....'
4. See error

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots
If applicable, add screenshots to help explain your problem.

Hardware

• Device: [e.g. Desktop, phone, VR headset]
• OS: [e.g. Windows, iOS, Linux]
• Browser [e.g. Firefox]

Additional context
Add any other context about the problem here.

┆Issue is synchronized with this Jira Task

[emclaren]

Just wanted to note that this is an issue that was also mentioned by a community member in an email last week

[oli414]

I've been able to find a pattern with this issue.

Our scene appears to have working teleports, but as soon as a user spawns an object in the scene, the teleports instead reloads the page. I've been able to reproduce the issue on both Chrome and Firefox so I think it's fair to say that this might somehow be the cause of the issue.

However:
This issue doesn't occur if your url has a trailing /
https://hubs.mozilla.com/edYu459/loyal-giant-gala will have the issue but https://hubs.mozilla.com/edYu459/loyal-giant-gala/ will not.

Temporary Fix:
Make sure that the room URL you share ends with a slash.

[Charlesc22]

We've also seen this bug, but have not drilled down to find the pattern. will check for the forward slash at the end though
Thanks for the tip @oli414

[Exairnous]

From testing I've done it appears that links to a waypoint will reload the room if the link address does not match the current room URL regarding the trailing slash. This is why adding an object (or changing avatars, etc.) will cause links to reload the room if a trailing slash is not included, because opening the object place menu will add a trailing slash to the current room URL (but the link URL doesn't contain a trailing slash). The room will also be reloaded if the waypoint link URL contains a trailing slash, but the room URL does not (they must match or the room will reload).

The only way I've found to reliably work with waypoint links is to setup a link (or image with href) to contain the full room address, including a trailing slash, then the #WAYPOINTNAME, and then give everyone the room link with the trailing slash (potentially including query string parameters after the slash); the downside with this is that the favorite room links don't include the trailing slash, so if you visit a room from your favorites menu with waypoint links you'll run into the reloading problem :(

Example links:

WORKS ALL OF THE TIME:
waypoint link: https://hubs.mozilla.com/<room-code>/<room-name>/#WAYPOINTNAME
room link: https://hubs.mozilla.com/<room-code>/<room-name>/

WORKS SOME OF THE TIME (will work until some dialog changes the room URL to contain a slash):
waypoint link: https://hubs.mozilla.com/<room-code>/<room-name>#WAYPOINTNAME
room link: https://hubs.mozilla.com/<room-code>/<room-name>

NEVER WORKS:
waypoint link: https://hubs.mozilla.com/<room-code>/<room-name>#WAYPOINTNAME
room link: https://hubs.mozilla.com/<room-code>/<room-name>/
OR
waypoint link: https://hubs.mozilla.com/<room-code>/<room-name>/#WAYPOINTNAME
room link: https://hubs.mozilla.com/<room-code>/<room-name>

[yakyouk]

Created #4272 to fix this; not sure how to have that pull request automatically link to this issue.

[Exairnous]

#4272 has been merged and I can confirm that this has been fixed in both Chromium 91.0.4472.77 and Firefox 89.0 in Linux.