Merge pull request #4253 from mozilla/fix-light-cloning

When we clone a light we need to update its target

src/components/avatar-audio-source.js

@@ -151,14 +151,14 @@ AFRAME.registerComponent("avatar-audio-source", {
 });
 
 function createWhiteNoise(audioContext, gain) {
-  var bufferSize = 2 * audioContext.sampleRate,
+  const bufferSize = 2 * audioContext.sampleRate,
     noiseBuffer = audioContext.createBuffer(1, bufferSize, audioContext.sampleRate),
     output = noiseBuffer.getChannelData(0);
-  for (var i = 0; i < bufferSize; i++) {
+  for (let i = 0; i < bufferSize; i++) {
     output[i] = (Math.random() * 2 - 1) * gain;
   }
 
-  var whiteNoise = audioContext.createBufferSource();
+  const whiteNoise = audioContext.createBufferSource();
   whiteNoise.buffer = noiseBuffer;
   whiteNoise.loop = true;
   whiteNoise.start(0);

src/react-components/preferences-screen.js

@@ -350,7 +350,9 @@ function ListItem({ children, disabled, indent }) {
   return <div className={classNames(styles.listItem, { disabled, indent })}>{children}</div>;
 }
 ListItem.propTypes = {
-  children: PropTypes.node.isRequired
+  children: PropTypes.node.isRequired,
+  disabled: PropTypes.bool,
+  indent: PropTypes.bool
 };
 
 const preferenceLabels = defineMessages({
@@ -384,7 +386,7 @@ const preferenceLabels = defineMessages({
   },
   enableAECHack: {
     id: "preferences-screen.preference.enable-echo-cancellation-hack",
-    defaultMessage: "Enable agressive echo cancellation (significantly reduces audio quality)"
+    defaultMessage: "Enable aggressive echo cancellation (significantly reduces audio quality)"
   },
   disableNoiseSuppression: {
     id: "preferences-screen.preference.disable-noise-suppression",

src/react-components/room/ContentMenu.js

@@ -41,6 +41,9 @@ export function PeopleMenuButton(props) {
     </ContentMenuButton>
   );
 }
+PeopleMenuButton.propTypes = {
+  presenceCount: PropTypes.number
+};
 
 export function ContentMenu({ children }) {
   return <div className={styles.contentMenu}>{joinChildren(children, () => <div className={styles.separator} />)}</div>;

src/react-components/room/TipContainer.js

@@ -15,7 +15,8 @@ let turnRightKey = "E";
 // implimentation we may want to cook up our own polyfill based on observing key inputs
 if (window.navigator.keyboard !== undefined && window.navigator.keyboard.getLayoutMap) {
   window.navigator.keyboard.getLayoutMap().then(function(map) {
-    moveKeys = `${map.get("KeyW") || "W"} ${map.get("KeyA") || "A"} ${map.get("KeyS") || "S"} ${map.get("KeyD") || "D"}`.toUpperCase()
+    moveKeys = `${map.get("KeyW") || "W"} ${map.get("KeyA") || "A"} ${map.get("KeyS") || "S"} ${map.get("KeyD") ||
+      "D"}`.toUpperCase();
     turnLeftKey = map.get("KeyQ")?.toUpperCase();
     turnRightKey = map.get("KeyE")?.toUpperCase();
   });

src/utils/three-utils.js

@@ -166,6 +166,10 @@ export function cloneObject3D(source, preserveUUIDs) {
       clonedNode.geometry.boundsTree = sourceNode.geometry.boundsTree;
     }
 
+    if ((clonedNode.isDirectionalLight || clonedNode.isSpotLight) && sourceNode.target) {
+      clonedNode.target = cloneLookup.get(sourceNode.target);
+    }
+
     if (!sourceNode.isSkinnedMesh) return;
 
     const sourceBones = sourceNode.skeleton.bones;