Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Host header to Hubs Cloud CloudFront behavior to fix upload requests #134

Merged
merged 1 commit into from
Dec 1, 2021

Conversation

brianpeiris
Copy link
Contributor

In Hubs-Foundation/reticulum#508 we added a restriction that prevents uploads being served from the primary domain. That change worked on HMC, but not on the current Hubs Cloud release candidate, since the CloudFront configuration in our CloudFormation stack is not configured to pass the Host header along to the server. As a result, uploaded files, including scenes and avatars fail to load.
This PR adds the required header to fix this issue.

@robinkwilson
Copy link
Contributor

Lgtm

@robinkwilson robinkwilson merged commit ff5eab5 into master Dec 1, 2021
@robinkwilson robinkwilson deleted the fix-uploads branch December 1, 2021 00:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants