Add bloom to environment settings #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've just done a quick scan of the code so far, but it seems generally good. One thing I noticed is that I think it might be better if settings like "enableHDRPipeline" and "enableBloom" are always included in the export so that importing them is easier. I think the stuff under those bools is fine to leave out if false though (i.e. the enableHDRPipeline is always there, if it's false don't include anything after, but if it's true then include the enableBloom, and so on). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a checkbox for 'HDR render pipeline" which allows configuring bloom settings. It should be considered experimental and checking this box will opt you into some future breaking scene changes that may require a re-export. (The first of which will likely be automatic application of PI on lightmap intensity when needed).
When this is enabled tonemapping mode will currently be ignored and ACES will always be used. You can still set an exposure, though its meaning may change at some point. This will likely become configurable again in the future but with different options (hopefully with adaptive exposure and custom LUT).
See Hubs-Foundation/hubs#5742 for more details