Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

README: markdown formatting in the "Further Options" table #60

Closed
wants to merge 1 commit into from
Closed

README: markdown formatting in the "Further Options" table #60

wants to merge 1 commit into from

Conversation

aceyoung9
Copy link

Before:

screen shot 2017-04-12 at 2 48 24 am

After:

screen shot 2017-04-12 at 2 49 05 am

@aceyoung9
README: Remove leading tabs from the rows in the "Further options" ta…
c74918e 
…ble,

such that table can render on Github.com interface.
@JHilker
Copy link
Contributor

JHilker commented Apr 12, 2017

Thanks a ton for the PR!

Though it looks like this was also broken in the upstream and fixed recently by JedWatson/react-select@14f199c#diff-04c6e90faac2675aa89e2176d2eec7d8

I imagine we'll want to pick that up when the next release comes out to avoid potential conflicts, but defer to @TrevorBurnham on that one.

@TrevorBurnham
Copy link
Contributor

Yes, this was fixed by an upstream change, which has been merged as part of #62. Thanks!

@aceyoung9
Copy link
Author

Cool thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aceyoung9 @JHilker @TrevorBurnham