Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge Creatable updates from upstream #42

Merged
merged 29 commits into from
Oct 25, 2016
Merged

Conversation

TrevorBurnham
Copy link
Contributor

This PR merges JedWatson/react-select#1207 and JedWatson/react-select#1213 into react-select-plus. Both PRs update the new Creatable feature. The first allows it to be used in conjunction with Async. The latter fixes some bugs, notably one that prevented the same tag from being created multiple times:

Before

before

After

after

Aeon and others added 29 commits September 1, 2016 13:39
Frequently getting this warning:

> warning.js?85a7:36Warning: Unknown prop `minWidth` on <input> tag. Remove this prop from the element. 

which means that somehow the plain html input is being used instead of AutosizeInput. Also, having two references that differ only in case is just begging for user error.
…showing how to highlight matching search text using a custom optionRenderer.
Added arrowRenderer prop and updated examples.
Rename autosize "Input" references to "AutosizeInput"
Following a child-function pattern. Tests have been added.
Document promptTextCreator property of Creatable.
Do not focus and open menu when disabled
Creatable and Async components can compose each other
Added check for invalid filterOptions return value to Creatable
@TrevorBurnham TrevorBurnham merged commit e7302ba into master Oct 25, 2016
@TrevorBurnham TrevorBurnham deleted the fix-create-tag-again branch October 25, 2016 20:58
@TrevorBurnham
Copy link
Contributor Author

Published as 1.0.0-rc.1.patch2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants