HubSpot Backport: HBASE-28568 Incremental backup set does not correctly shrink (#5876) #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndimiduk
requested review from
charlesconnell,
bbeaudreault,
rmdmattingly and
ksravista
rmdmattingly
force-pushed
the
28568-hubspot-2.6
branch
from
0a5a7ff to
8ab2e36
Compare
|
This needs the addendum. Once sec. |
…ly shrink (apache#5876) The incremental backup set is the set of tables included when an incremental backup is created, it is managed per backup root dir and contains all tables that are present in at least one backup (in that root dir). The incremental backup set can only shrink when backups are deleted. However, the implementation was incorrect, causing this set to never be able to shrink. Reviewed-by: Ray Mattingly <[email protected]> Signed-off-by: Nick Dimiduk <[email protected]>
…ly shrink (addendum) (apache#5917) Import the correct shaded Guava and run spotless:apply. Signed-off-by: Duo Zhang <[email protected]>
ndimiduk
force-pushed
the
28568-hubspot-2.6
branch
from
8ab2e36 to
cab0470
Compare
|
Okay this one should be good to validate. Sorry for the delay @rmdmattingly . |
rmdmattingly
approved these changes
Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The incremental backup set is the set of tables included when an incremental backup is created, it is managed per backup root dir and contains all tables that are present in at least one backup (in that root dir).
The incremental backup set can only shrink when backups are deleted. However, the implementation was incorrect, causing this set to never be able to shrink.
Reviewed-by: Ray Mattingly [email protected]