Fix undefined state on prop change #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| ): Object { | ||
| return oFilterMap( | ||
| dependencies, | ||
| (dep) => dep.deref && dep.deref.length > 0, | ||
| (dep) => calculate(dep, props) | ||
| (dep) => calculate(dep, props, state) |
There was a problem hiding this comment.
mmm so I think the only thing I would change is that, if the the deref doesn't declare a state argument (i.e. the argument at index 1) it shouldn't receive it.
return oFilterMap(
...,
(dep) => {
if (dep.deref.length === 1) {
return caluclate(dep, props);
}
return calculate(dep, props, state);
}
);There was a problem hiding this comment.
@marcneuwirth sorry I was thinking too hard... caclulate does the arity check, it was good the way you had it. Changed it back 8906900.
|
@marcneuwirth one comment, otherwise looks good. Once that's fixed I'll merge and publish. Thanks 🌴 |
|
Updated, thanks @colbyr |
|
@marcneuwirth published as version 1.2.2 |
|
👍 thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because
timesAHundredMinusStatenever actually usedstate, it was unnoticed thatstatewould beundefinedwhen thederefwas called fromcomponentWillReceiveProps. This change should pass the currentstatethrough at the time ofcomponentWillReceivePropsand update the tests to reflect that case.It looks like the Change log wasnt updated for v1, so I also didn't add anything for this fix. If there is anything else that I missed, let me know.
/cc @colbyr