Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

throw if more than one mixin is detected + initialize in getInitialState #45

Merged
merged 2 commits into from
Jul 6, 2016

Conversation

colbyr
Copy link
Contributor

@colbyr colbyr commented Jul 6, 2016

Adds an invariant that checks if another StoreDependencyMixin has already been initialized on the component. Currently that wouldn't work but it wouldn't work silently and end up throwing in componentWillUnmount.

Also initializes the mixin in getInitialState to maintain backwards compatibility and get state key conflict errors.

@colbyr colbyr merged commit f9429b6 into master Jul 6, 2016
@colbyr colbyr deleted the only-one-mixin branch July 6, 2016 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant