code review fixups

HubSpot · Nov 19, 2019 · 706543e · 706543e
1 parent 1505279
commit 706543e
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/src/dependencies/__tests__/useStoreDependency-test.js b/src/dependencies/__tests__/useStoreDependency-test.js
@@ -182,6 +182,7 @@ describe('useStoreDependency', () => {
       // not implemented correctly, as the immutables will not be strictly
       // equal, sending useStoreDependency into an infinite loop
       // https://github.com/HubSpot/general-store/issues/74
+      expect(true).toBe(true);
     });
   });
 

diff --git a/src/utils/ObjectUtils.ts b/src/utils/ObjectUtils.ts
@@ -79,7 +79,7 @@ export function shallowEqual(obj1: any, obj2: any): Boolean {
     // https://github.com/immutable-js/immutable-js/blob/59c291a2b37693198a0950637c5d55cd14dd6bc4/src/is.js#L52-L55
     if (obj1.hashCode() !== obj2.hashCode()) {
       return false;
-    } else {
+    } else if (typeof obj1.equals === 'function') {
       return obj1.equals(obj2);
     }
   }