Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional renderTray render prop to Editor #36

Merged
merged 3 commits into from
Nov 6, 2018

Conversation

blwsk
Copy link
Contributor

@blwsk blwsk commented Nov 6, 2018

Changes made:

  • Add optional renderTray render prop to Editor component
  • Add /examples/tray.html outlining the new feature
  • Some "prettier" changes

Rationale:

We've built a fairly complex "message composer" component on top of draft-extend. The controls section of the Editor component contains a toolbar with many plugin buttons. Given the design we're trying to achieve, we need to access the space between the main input and the controls area in order to display validation messages and "stage" yet-to-be-published file attachment and images.

screen shot 2018-11-06 at 3 58 05 pm

@benbriggs
Copy link
Contributor

👍 thank you!

@benbriggs benbriggs merged commit 1cf260b into HubSpot:master Nov 6, 2018
@blwsk blwsk deleted the krb-tray branch November 6, 2018 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants